fix(interpreter): prevent byte range panic in ${#arr[idx]} with malformed input#1110
Merged
fix(interpreter): prevent byte range panic in ${#arr[idx]} with malformed input#1110
Conversation
…rmed input The WordPart::Length handler searched for ']' from the start of the name string, but '[' could appear after ']' in malformed input (e.g. fuzz input with null bytes). This caused `name[bracket_pos + 1..index_end]` to panic with "byte range starts at 43 but ends at 8" when bracket_pos + 1 > index_end. Fix by searching for ']' starting from the '[' position, ensuring the closing bracket is always after the opening bracket. Closes #1090
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WordPart::Lengthhandler when malformed input has]before[]from the start of the string, but[could appear later, causingname[bracket_pos + 1..index_end]to panic with reversed byte range]starting from the[positionChanges
interpreter/mod.rs: search for]relative to[position inWordPart::Lengthhandlerbyte_range_panic_tests.rs: 3 regression tests including decoded fuzz crash inputTest plan
cargo test --test byte_range_panic_tests— 3 new tests passcargo test --all-features -- --skip ssh_supabase— all passcargo clippy --all-targets --all-features -- -D warnings— cleanCloses #1090